for directive specific word element handling #150
Merged
+397
−136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the handling of for directive elements, recognizing "_has_next" as Boolean and "_index" as Integer types for improved code completion, documentation, and inspections.
- Introduces new SQL test files to verify proper handling of these elements.
- Updates DAO interfaces and inspection/documentation generators to utilize the specified types.
- Adjusts the ForDirectiveUtil utility to resolve type suffixes accordingly.
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| documentForItemIndex.sql | Added SQL test for handling item_index with Boolean/Integer types. |
| documentForItemHasNext.sql | Added SQL test for handling item_has_next with Boolean type. |
| completeForItemIndex.sql | Added SQL test for code completion of item_index. |
| completeForItemHasNext.sql | Added SQL test for code completion of item_has_next. |
| EmployeeSummaryDao/bindVariableForItemHasNextAndIndex.sql | Added SQL test for binding variables with both for directive properties. |
| DocumentTestDao.java, SqlCompleteTestDao.java, EmployeeSummaryDao.java | Updated DAO interfaces to include methods for the new tests. |
| Various Kotlin test and provider files | Updated inspection and documentation generators to resolve for directive types. |
| ForDirectiveUtil.kt | Added new method to resolve type suffixes to standard Java classes. |
Comments suppressed due to low confidence (3)
src/test/testData/src/main/resources/META-INF/doma/example/dao/document/DocumentTestDao/documentForItemIndex.sql:4
- [nitpick] The token 'item_index' appears to contain a typo; please ensure the identifier is spelled correctly as 'item_index' for consistency with the intended type resolution.
index = /* item_in<caret>dex */0
src/test/testData/src/main/resources/META-INF/doma/example/dao/EmployeeSummaryDao/bindVariableForItemHasNextAndIndex.sql:20
- The reference 'member_has_next.NotTRUE' does not match any known Boolean field or constant; please update it to a valid reference that correctly resolves to a Boolean value.
and p.not_next = /* member_has_next.NotTRUE */false
src/test/testData/src/main/resources/META-INF/doma/example/dao/EmployeeSummaryDao/bindVariableForItemHasNextAndIndex.sql:22
- The reference 'member_index.nextValue()' does not correspond to any valid method or field for an Integer type; please replace it with the appropriate reference, such as a valid static constant or method invocation.
and p.not_index = /* member_index.nextValue() */999
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the handling of for directive elements, recognizing "_has_next" as Boolean and "_index" as Integer types for improved code completion, documentation, and inspections.